[U-Boot] [PATCH v3 11/11] sunxi: Add PSCI implementation in C

Chen-Yu Tsai wens at csie.org
Mon Jun 13 04:50:42 CEST 2016


On Fri, Jun 10, 2016 at 9:40 PM, Hans de Goede <hdegoede at redhat.com> wrote:
> Hi,
>
> On 07-06-16 04:54, Chen-Yu Tsai wrote:
>>
>> To make the PSCI backend more maintainable and easier to port to newer
>> SoCs, rewrite the current PSCI implementation in C.
>>
>> Some inline assembly bits are required to access coprocessor registers.
>> PSCI stack setup is the only part left completely in assembly. In theory
>> this part could be split out of psci_arch_init into a separate common
>> function, and psci_arch_init could be completely in C.
>>
>> Signed-off-by: Chen-Yu Tsai <wens at csie.org>
>
>
> I tried merging this in my tree to add it to u-boot-sunxi/next, but
> unfortunately it triggers a bug in gcc-6.1, I've filed a bug with
> gcc to get this fixed:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1344717

Interesting. Seems like the compiler should be emitting LDMFD instead
of POP, or a POP followed by a SUBS/MOVS.

>
> Also cp15_read_scr / cp15_write_scr are missing __secure notations.

Do you want me to send a new version for this?

ChenYu

> Regards,
>
> Hans


More information about the U-Boot mailing list