[U-Boot] [PATCH v2 0/5] Urgent fixes for misconverted CONFIG_BOOTDELAY

yamada.masahiro at socionext.com yamada.masahiro at socionext.com
Mon Jun 13 09:53:02 CEST 2016


Hi Heiko.

> Hmm... didn;t you had a script, with which you checked all board binaries
> if they are the same before and after one patch? That could be a solution
> for doing such Kconfig moves ...

When I converted lots of Makefiles for Kbuild migration more than 2 years ago,
I hacked  include/timestamp.h, include/version.h, and MAKEALL
to show MD5SUM for each board.

I noted a small tip in the page 9 of the following slide:
http://www.denx.de/wiki/pub/U-Boot/MiniSummitELCE2014/uboot2014_kconfig.pdf

But, MAKEALL will be removed sooner or later.


Instead, I found an interesting option in Buildman.

  -K, --show-config     Show configuration changes in summary (both board
                        config files and Kconfig)


I tried it, but the output seems too noisy to check the diff...
(unless I am missing something.)



> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: Monday, June 13, 2016 2:42 PM
> To: Yamada, Masahiro/山田 真弘
> Cc: Tom Rini; Steve Rae; Lucas Stach; Dimitar Penev; Viresh Kumar; Lars
> Poeschel; Albert ARIBAUD (3ADEV); U-Boot Mailing List; Magnus Lilja; Soeren
> Moch; Przemyslaw Marczak; Eric Bénard; Valentin Yakovenkov; Wolfgang
> Wegner; Stefan Roese; Mark Jonas; Richard Hu; Chander Kashyap; Valentin
> Longchamp; Akshay Saraswat; Stephen Warren; Otavio Salvador; Angelo
> Dureghello; Peter Meerwald; Thomas Lange; Thomas Abraham; Holger Brunck;
> Ash Charles; Ian Campbell; Lauri Hintsala; Markus Niebel; Stefan Agner;
> Sergei Poselenov; Tim Kryger; Thomas Weber; Gilles Gameiro; Robert Baldyga;
> Phil Han; Lucile Quirion; Lukasz Dalek; Adrian Alonso; Fabio Estevam; Sergey
> Kostanbaev; Christophe Ricard; Zoltan Herpai; Nobuhiro Iwamatsu; Oleksandr
> Zhadan and Michael Durrant; Vladimir Zapolskiy; Aleksei Mamlin; Po Liu;
> Vipin Kumar; Gong Qianyu; Priit Laes; huang lin; Marcel Ziswiler; Joe
> Hershberger; Werner Pfister; Felipe Balbi; Kamil Lulko; Marcus Cooper; Tom
> Warren; Lothar Felten; I-SYST Micromodule; Enric Balletbo i Serra; Jelle
> de Jong; M.Hasewinkel (MHA); Alban Bedel; Daniel Allred; TsiChung Liew
> Subject: Re: [U-Boot] [PATCH v2 0/5] Urgent fixes for misconverted
> CONFIG_BOOTDELAY
> 
> Hello Masahiro,
> 
> Am 13.06.2016 um 01:15 schrieb Masahiro Yamada:
> > Hi Tom,
> >
> >
> > 2016-06-13 6:07 GMT+09:00 Masahiro Yamada
> <yamada.masahiro at socionext.com>:
> >> Hi Tom,
> >>
> >> 2016-06-13 1:50 GMT+09:00 Tom Rini <trini at konsulko.com>:
> >>> On Sat, Jun 11, 2016 at 06:44:07PM +0900, Masahiro Yamada wrote:
> >>>
> >>>>
> >>>> Masahiro Yamada (5):
> >>>>    ARM: stm32: remove unused CONFIG_AUTOBOOT
> >>>>    autoboot: follow-up cleanup after CONFIG_BOOTDELAY moves
> >>>>    tools: fix define2mk.sed to not add quotes around negative integers
> >>>>    autoboot: fix a bunch of misconversion of CONFIG_BOOTDELAY
> >>>>    autoboot: add CONFIG_AUTOBOOT to allow to not compile autoboot.c
> >>>
> >>> Please put together a PR with everything except the defconfig
> >>> changes, along with the other moveconfig.py related fixes for me and
> >>> I'll go unbreak everything (along with Hans' patch).  Thanks!
> >>
> >>
> >> Please let me confirm the ones I should include in my PR.
> >>
> >> moveconfig patches and these three?
> >>
> >>>>    ARM: stm32: remove unused CONFIG_AUTOBOOT
> >>>>    autoboot: follow-up cleanup after CONFIG_BOOTDELAY moves
> >>>>    tools: fix define2mk.sed to not add quotes around negative
> >>>> integers
> >>
> >
> > Done.
> >
> >
> > BTW, would you consider changing the default of BOOTDELAY from 0 to 3
> > ?
> 
> Damn, Tom suggested me to change it to 2 .... and in my rebase to
> 2016.05-rc1 accidently I used the wrong value
> 
> I am sorry for all the trouble ...
> 
> Hmm... didn;t you had a script, with which you checked all board binaries
> if they are the same before and after one patch? That could be a solution
> for doing such Kconfig moves ...
> 
> bye,
> Heiko
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list