[U-Boot] [PATCH v5 0/8] ARMv7: PSCI: add PSCI v1.0 support

[Marc Zyngier]

On Wed, 15 Jun 2016 15:16:08 +0800
Chen-Yu Tsai <wens at csie.org> wrote:

> Hi,
> 
> On Tue, Jun 14, 2016 at 3:01 PM,  <macro.wave.z at gmail.com> wrote:
> > From: Hongbo Zhang <hongbo.zhang at nxp.com>
> >
> > v5 changes:
> > - Give up fixing the potential bug of PSCI stack overlap with secure text end
> > when there is more CPUs in system. Because I just want to keep this series as
> > simple as it could be: adding basic PSCI v1.0 support and adding more PSCI
> > v1.0 implements of our platform.
> > While too compplicated patches in assembly language won't call for effective
> > reviews, even I think there is potential bug of PSCI stack, let's fix it in
> > sepetated patch later.  

And have silent corruption from the secure side? I hope not.

> 
> I've done some patches fixing the stack allocation issue:
> 
> https://github.com/wens/u-boot-sunxi/commits/c-psci-part2
> 
> These patches are ready, but I want to add a secure data section still.
> The data section will be for variables such as target PC, core/cluster
> power status, context ID, etc.. IMHO this is better than putting stuff
> at the top or bottom of the stack, and can also be referenced directly.

I haven't looked at these patches, but I definitely welcome that kind
of development. Please also consider providing some form of per-cpu
infrastructure (which would in turn solve the issue that Hongbo Zhang
wants to sidestep).

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.