[U-Boot] [PATCH] ARM: board: cm-fx6: fix mmc for old revisions of utilite

[Christopher Spinrath]

Hi Nikita,

On 06/15/2016 05:15 PM, Nikita Kiryanov wrote:
> Hi CHristopher,
> 
> On Wed, Jun 08, 2016 at 09:02:36PM +0200, Christopher Spinrath wrote:
>> Old revisions of Utilite (based on cmfx6) do not have a dedicated
>> card detect pin. But the card is removable by the user and card
>> detection can be realized with polling (e.g. supported by Linux).
>>
>> Add the broken-cd property to the mmc device tree instead of the
>> non-removable property to make card detection possible if polling
>> is supported.
> 
> Acked-by: Nikita Kiryanov <nikita at compulab.co.il>

How is this patch (and, in general, patches for Utilite/cm-fx6) supposed
to be merged? Due to get_maintainers your are (the only) maintainer
related to the cm-fx6 board. Do you want me to resend the patch (without
the Fixes: tag)?

> One nit-pick below:
> 
>>
>> Fixes: 41855186afd3 ("arm: mx6: cm-fx6: modify device tree for old revisions of utilite")
> 
> This isn't technically a fix; you're enabling new functionality. The
> original behavior wasn't buggy, it just lacked the card detect feature.
>
Well, the card is clearly removable. So IMHO adding the non-removable
property is wrong and this patch corrects/fixes it. But I'm fine either way.

Thanks,
Christopher


>> Signed-off-by: Christopher Spinrath <christopher.spinrath at rwth-aachen.de>
>> ---
>>  board/compulab/cm_fx6/cm_fx6.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> -- 
>> 2.8.3
>>
> 
> Regards,
> Nikita Kiryanov 
>