[U-Boot] [PATCH] Drivers: SPI: spi_slave struct has no member called bus nor cs.

Simon Glass sjg at chromium.org
Fri Jun 17 05:50:01 CEST 2016


Hi Ahmen,

On 11 June 2016 at 13:47, Ahmed Samir Khalil <engkhalil86 at gmail.com> wrote:
> In case of Driver Model, spi_slave structure (in spi.c) doesn't
> have member called bus or cs. Compiler error will be reported
> when using the new Driver Model while assigning bus & cs to
> non-members. This compiler error becomes obvious while applying
> the step-by-step documented in spi-howto.txt
>
> Signed-off-by: Ahmed Samir Khalil <engkhalil86 at gmail.com>
> ---
>  drivers/spi/spi.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index 7d81fbd..b02c7ab 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -31,8 +31,10 @@ void *spi_do_alloc_slave(int offset, int size, unsigned int bus,
>         if (ptr) {
>                 memset(ptr, '\0', size);
>                 slave = (struct spi_slave *)(ptr + offset);
> +#ifndef CONFIG_DM_SPI
>                 slave->bus = bus;
>                 slave->cs = cs;
> +#endif
>                 slave->wordlen = SPI_DEFAULT_WORDLEN;
>         }
>

This file should not be built when CONFIG_DM_SPI is enabled. Are you
using the latest mainline U-Boot?

Regards,
Simon


More information about the U-Boot mailing list