[U-Boot] SPL: fat: Fix spl_parse_image_header() return value handling

Marek Vasut marex at denx.de
Fri Jun 17 17:06:05 CEST 2016


On 06/17/2016 05:01 PM, Fabio Estevam wrote:
> Hi Tom,
> 
> On Mon, May 23, 2016 at 7:14 PM, Tom Rini <trini at konsulko.com> wrote:
>> On Fri, May 20, 2016 at 01:45:24AM +0200, Marek Vasut wrote:
>>
>>> The spl_parse_image_header() can return 0 and it is not an error.
>>> Only treat non-zero return value as an error.
>>>
>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>> Cc: Fabio Estevam <fabio.estevam at nxp.com>
>>> Cc: Peng Fan <van.freenix at gmail.com>
>>> Cc: Stefano Babic <sbabic at denx.de>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
>>> Reviewed-by: Peng Fan <van.freenix at gmail.com>
>>> Reviewed-by: Stefano Babic <sbabic at denx.de>
>>> Reviewed-by: Tom Rini <trini at konsulko.com>
>>
>> Applied to u-boot/master, thanks!
> 
> Looks like something went wrong while applying this patch as Marek's
> authorship got lost:

Ah, you're right, nice catch :)

Tom, I don't really care, bug is fixed, you can leave it as it is.

> commit d550e82e4efebf5995809e38e8fb029b8fe6e861
> Author: Tom Rini <trini at konsulko.com>
> Date:   Mon May 23 11:51:13 2016 -0400
> 
>     SPL: fat: Fix spl_parse_image_header() return value handling
> 
>     The spl_parse_image_header() can return 0 and it is not an error.
>     Only treat non-zero return value as an error.
> 
>     Signed-off-by: Marek Vasut <marex at denx.de>
>     Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
>     Reviewed-by: Peng Fan <van.freenix at gmail.com>
>     Reviewed-by: Stefano Babic <sbabic at denx.de>
>     Reviewed-by: Tom Rini <trini at konsulko.com>
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list