[U-Boot] [PATCH] NFS: Add error message when U-Boot NFS version (V2) is not supported by NFS server

Joe Hershberger joe.hershberger at gmail.com
Fri Jun 17 18:28:11 CEST 2016


Hi Guillaume,

On Mon, Jun 6, 2016 at 8:11 AM, Guillaume GARDET
<guillaume.gardet at free.fr> wrote:
> Signed-off-by: Guillaume GARDET <guillaume.gardet at free.fr>
> Cc: joe.hershberger at ni.com
>
> ---
>  net/nfs.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/net/nfs.c b/net/nfs.c
> index 78968d8..0ed47c9 100644
> --- a/net/nfs.c
> +++ b/net/nfs.c
> @@ -481,8 +481,22 @@ static int nfs_lookup_reply(uchar *pkt, unsigned len)
>         if (rpc_pkt.u.reply.rstatus  ||
>             rpc_pkt.u.reply.verifier ||
>             rpc_pkt.u.reply.astatus  ||
> -           rpc_pkt.u.reply.data[0])
> +           rpc_pkt.u.reply.data[0]){
> +               switch(ntohl(rpc_pkt.u.reply.astatus)){

There are 7 checkpatch.pl issues with this patch. I'll fix them when I
apply it, but in the future, please at least run checkpatch and follow
the coding conventions. Even better would be to use tools/patman.

...

-Joe


More information about the U-Boot mailing list