[U-Boot] [PATCH v2] usb: fsl: Fix NULL terminating issue for usb controller name string

Marek Vasut marex at denx.de
Sat Jun 18 20:11:38 CEST 2016


On 06/18/2016 07:17 AM, Rajesh Bhagat wrote:
> Fixes NULL terminating issue for usb controller name string by using
> sizeof operator.
> 
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat at nxp.com>

Applied, thanks.

> ---
>  drivers/usb/host/ehci-fsl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Changelog for V2 is missing btw.

> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index a43d37d..fa916ed 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -65,7 +65,8 @@ int ehci_hcd_init(int index, enum usb_init_type init,
>  		mdelay(5);
>  	}
>  	memset(current_usb_controller, '\0', 5);
> -	snprintf(current_usb_controller, 4, "usb%d", index+1);
> +	snprintf(current_usb_controller, sizeof(current_usb_controller),
> +		 "usb%d", index+1);
>  
>  	switch (index) {
>  	case 0:
> 


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list