[U-Boot] [PATCH v3] Kconfig: Add a new DISTRO_DEFAULTS Kconfig option

[Masahiro Yamada]

2016-06-21 6:16 GMT+09:00 Hans de Goede <hdegoede at redhat.com>:
> DISTRO_DEFAULTS is intended to mirror / replace
> include/config_distro_defaults.h.
>
> The intend is for boards which include this file to select this from
> their Kconfig files and when moving setting to Kconfig which are #define-ed
> in config_distro_defaults.h to select this from DISTRO_DEFAULTS so that
> boards which have selected DISTRO_DEFAULTS will keep the same configuration
> as before without needing any defconfig file changes.
>
> The initial list of selected things matches all settings recently removed
> from config_distro_defaults.h because they have been converted to Kconfig,
> with the exception of CMD_ELF and CMD_NET, which have a default of y, if
> the default of these ever changes they should be selected by DISTRO_DEFAULTS
> too.
>
> For testing and example purposes this commit also converts ARCH_SUNXI
> to use DISTRO_DEFAULT instead of selecting everything it needs itself.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
> Changes in v2:
> -Use "default y if ARCH_SUNXI" instead of selecting DISTRO_DEFAULT for sunxi
> -Document how to enable DISTRO_DEFAULT in doc/README.distro
> Changes in v3:
> -Rebase on latest master
> ---
>  Kconfig           | 17 +++++++++++++++++
>  arch/arm/Kconfig  |  9 ---------
>  doc/README.distro |  6 ++++++
>  3 files changed, 23 insertions(+), 9 deletions(-)
>
> diff --git a/Kconfig b/Kconfig
> index 817f4f0..3ceff25 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -53,6 +53,23 @@ config CC_OPTIMIZE_FOR_SIZE
>
>           This option is enabled by default for U-Boot.
>
> +config DISTRO_DEFAULTS
> +       bool "Select defaults suitable for booting general purpose Linux distributions"
> +       default y if ARCH_SUNXI



If we want to allow users to disable distro,
and do not want ARCH_SUNXI appear in a generic config entry,
perhaps we can do like this.


config ARCH_SUNXI
       bool
       select ARCH_SUPPORTS_DISTRO


config DISTRO_DEFAULTS
       bool "Select defaults suitable for booting general purpose
Linux distributions"
       default y if ARCH_SUPPORTS_DISTRO



Currently it is just fine,
but we might want to do something in the future
when we have more platforms to migrate to this way...

config DISTRO_DEFAULTS
     bool "Select defaults suitable for booting general purpose Linux
distributions"
     default y if (ARCH_SUNXI || ARCH_TEGRA || ARCH_HISI || ARCH_ZYNQMP ... )



> +       default n
> +       select CMD_BOOTZ
> +       select CMD_DHCP
> +       select CMD_EXT2
> +       select CMD_EXT4
> +       select CMD_FAT
> +       select CMD_FS_GENERIC
> +       select CMD_MII
> +       select CMD_PING
> +       select HUSH_PARSER

Do you mean all of these commands are mandatory for disto?
Or just recommended?




-- 
Best Regards
Masahiro Yamada