[U-Boot] [RFC PATCH v1 4/6] dra7x: spl: dfu: adding SPL-DFU support for dra7x platform

[B, Ravi]

Hi Lukasz

>>  #include <ti-usb-phy-uboot.h>
>>  #include <miiphy.h>
>>  #include <pcf8575.h>
>> +#include <spl.h>
>>  
>>  #include "mux_data.h"
>>  #include "../common/board_detect.h"
>> @@ -706,6 +707,22 @@ int spl_start_uboot(void)  }  #endif
>>  
>> +#ifdef CONFIG_SPL_DFU
>> +int spl_run_dfu(void)

>We can replace int with bool here.

Ok, make sense.

>> +{
>> +	int os_boot = 0;
>> +#ifdef CONFIG_SPL_DFU_SF
>> +	spl_dfu_cmd(0, "dfu_alt_info_qspi", "sf", "0:0:64000000:0");
                                                   ^^^^^^^^^^^^^^^
                                                   could you add some
                                                   description to this
                                                   magic value (as e.g.
                                                   comment) or replace
                                                   it with some #define?

Ok, I can use default CONFIG_XX use for SPI and make string to pass.

Regards
Ravi