[U-Boot] [PATCH] mmc: dw_mmc: fix the wrong AND operation

[Minkyu Kang]

Hi,

2016년 5월 13일 금요일, Jaehoon Chung<jh80.chung at samsung.com>님이 작성한 메시지:

> These condition checking are wrong.
> Original Author's intention might be "&" instead of "&&".
> It can know whether receive or transmit data request with
> BIT[4]/BIT[5] of RINTSTS register.
>
> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com <javascript:;>>
> ---
>  drivers/mmc/dw_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 7329f40..b04b176 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -121,7 +121,7 @@ static int dwmci_data_transfer(struct dwmci_host
> *host, struct mmc_data *data)
>
>                 if (host->fifo_mode && size) {
>                         if (data->flags == MMC_DATA_READ) {
> -                               if ((dwmci_readl(host, DWMCI_RINTSTS) &&
> +                               if ((dwmci_readl(host, DWMCI_RINTSTS) &
>                                      DWMCI_INTMSK_RXDR)) {
>                                         len = dwmci_readl(host,
> DWMCI_STATUS);
>                                         len = (len >> DWMCI_FIFO_SHIFT) &
> @@ -133,7 +133,7 @@ static int dwmci_data_transfer(struct dwmci_host
> *host, struct mmc_data *data)
>                                                      DWMCI_INTMSK_RXDR);
>                                 }
>                         } else {
> -                               if ((dwmci_readl(host, DWMCI_RINTSTS) &&
> +                               if ((dwmci_readl(host, DWMCI_RINTSTS) &
>                                      DWMCI_INTMSK_TXDR)) {
>                                         len = dwmci_readl(host,
> DWMCI_STATUS);
>                                         len = fifo_depth - ((len >>
> --
> 1.9.1
>
>
applied to u-boot-samsung.

Thanks,
Minkyu Kang


> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de <javascript:;>
> http://lists.denx.de/mailman/listinfo/u-boot
>


-- 
Thanks.
Minkyu Kang.