[U-Boot] [RFC PATCH v3 2/4] mtd: fix compiler warnings

Scott Wood oss at buserror.net
Wed Jun 29 03:17:57 CEST 2016


On Sat, 2016-03-12 at 14:48 -0800, Steve Rae wrote:
> - add missing declaration
> - update debug output format specifiers
> 
> Signed-off-by: Steve Rae <srae at broadcom.com>
> ---
> the checkpatch warning:
>   warning: cmd/mtdparts.c,1494: quoted string split across lines
> is for the existing code; it is not introduced with this change...
> 
> Changes in v3: None
> Changes in v2: None

Why is this an RFC patch?  It seems like an attempt to fix straightforward
problems, unrelated to the iproc driver.	

>  
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 9da77ec..9c36f02 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -495,5 +495,13 @@ int mtd_arg_off(const char *arg, int *idx, loff_t *off,
> loff_t *size,
>  int mtd_arg_off_size(int argc, char *const argv[], int *idx, loff_t *off,
>  		     loff_t *size, loff_t *maxsize, int devtype,
>  		     uint64_t chipsize);
> +
> +#ifdef CONFIG_CMD_MTDPARTS_SPREAD
> +/* drivers/mtd/mtdcore.c */
> +void mtd_get_len_incl_bad(struct mtd_info *mtd, uint64_t offset,
> +			  const uint64_t length, uint64_t *len_incl_bad,
> +			  int *truncated);
> +#endif /* CONFIG_CMD_MTDPARTS_SPREAD */

Don't ifdef prototypes.

-Scott



More information about the U-Boot mailing list