[U-Boot] [PATCH] x86: coreboot: Remove the dummy pch driver

Tom Rini trini at konsulko.com
Wed Jun 29 04:05:12 CEST 2016


On Wed, Jun 29, 2016 at 10:02:55AM +0800, Bin Meng wrote:
> On Wed, Jun 29, 2016 at 2:43 AM, Simon Glass <sjg at chromium.org> wrote:
> > On 22 June 2016 at 17:56, Bin Meng <bmeng.cn at gmail.com> wrote:
> >> Hi Simon,
> >>
> >> On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg at chromium.org> wrote:
> >>> Hi Bin,
> >>>
> >>> On 22 June 2016 at 03:30, Bin Meng <bmeng.cn at gmail.com> wrote:
> >>>> There is a dummy pch driver in the coreboot directory. This causes
> >>>> drivers of its children fail to function due to empty ops. Remove
> >>>> the whole file since it is no longer needed.
> >>>>
> >>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> >>>> ---
> >>>>
> >>>>  arch/x86/cpu/coreboot/Makefile |  1 -
> >>>>  arch/x86/cpu/coreboot/pci.c    | 26 --------------------------
> >>>>  2 files changed, 27 deletions(-)
> >>>>  delete mode 100644 arch/x86/cpu/coreboot/pci.c
> >>>
> >>> That was intended to support a PCH where U-Boot did not have to set it
> >>> up (when booting from coreboot). Is it not needed now?
> >>>
> >>
> >> This is not needed now. The pch7 and pch7 driver are built for
> >> coreboot too so that they can be used.
> >>
> >> Regards,
> >> Bin
> >
> > Thanks.
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Tom, will you apply this one directly for v2016.07 release?

Make a PR for me please, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160628/24850089/attachment.sig>


More information about the U-Boot mailing list