[U-Boot] [PATCH] arm: mmc: increase MMC SDHCI read status timeout

Steve Rae steve.rae at raedomain.com
Wed Jun 29 22:30:33 CEST 2016


Hi Masahiro,

On Wed, Jun 29, 2016 at 4:52 AM, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> Hi Steve,
>
>
>> @@ -127,6 +127,7 @@ static int sdhci_transfer_data(struct sdhci_host *host, struct mmc_data *data,
>>  #define CONFIG_SDHCI_CMD_MAX_TIMEOUT           3200
>>  #endif
>>  #define CONFIG_SDHCI_CMD_DEFAULT_TIMEOUT       100
>> +#define CONFIG_SDHCI_READ_STATUS_TIMEOUT       1000
>>
>>  static int sdhci_send_command(struct mmc *mmc, struct mmc_cmd *cmd,
>>                        struct mmc_data *data)
>
>
> When I see CONFIG_ prefix, I imagine this parameter can be configurable
> via Kconfig or board header,
> but this is not actually overridden.
>
that makes sense....

> Nor do I believe it should be moved to Kconfig,
> because I doubt it is a CONFIG.
>
correct!
so maybe the define should be  ? :
    SDHCI_READ_STATUS_TIMEOUT
>
> Setting such things aside, one important thing is,
> this patch fixes my problem.
>
>
>
> BTW, why did you add "arm: " to the git subject?
> Is this patch related to ARM?
>
no (sorry) , I don't think so....
>
>
> Otherwise,
>
> Tested-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>
>
> --
> Best Regards
> Masahiro Yamada


More information about the U-Boot mailing list