[U-Boot] [PATCH 2/2] dm: mmc: dwmmc: use the callback functions as static

[Simon Glass]

Hi Jaehoon,

On 28 June 2016 at 20:47, Jaehoon Chung <jh80.chung at samsung.com> wrote:
> Hi Simon,
>
> On 06/29/2016 12:28 PM, Simon Glass wrote:
>> Hi Jaehoon,
>>
>> On 27 June 2016 at 23:52, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>>> There are no places to call these functions.
>>> It should be used the callback function.
>>> Then it can be used as static functions.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>>> ---
>>>  drivers/mmc/dw_mmc.c | 4 ++--
>>>  include/dwmmc.h      | 3 ---
>>>  2 files changed, 2 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
>>> index 3411f95..f83a6bc 100644
>>> --- a/drivers/mmc/dw_mmc.c
>>> +++ b/drivers/mmc/dw_mmc.c
>>> @@ -182,7 +182,7 @@ static int dwmci_set_transfer_mode(struct dwmci_host *host,
>>>  }
>>>
>>>  #ifdef CONFIG_DM_MMC_OPS
>>> -int dwmci_send_cmd(struct udevice *dev, struct mmc_cmd *cmd,
>>
>>>From what I can see this is already static. Which commit are you basing off?
>
> I'm checking with your 'blk-working' branch. I'm not sure what's correct.
>
> commit dee390a1250c17a4e71e359d6e461319a7cdea54
> Author: Simon Glass <sjg at chromium.org>
> Date:   Sat Jun 11 19:01:49 2016 -0600
>
>     dm: blk: Enable CONFIG_BLK if DM_MMC is enabled
>
> If i need to work with other branch, let me know,plz.
> I have tested the DM with dw_mmc_exynos.c. (It's working fine.)
>
> I will send the patch-set for exynos dwmmc and sdhci controller.
> So i need to know which repository and branch are correct. :)
>
> Then it's helpful to me for working dm. I think that i can help you for checking on mmc side with DM.

OK I see, thanks.

Reviewed-by: Simon Glass <sjg at chromium.org>

[snip

Regards,
Simon