[U-Boot] [PATCH] fit_image: Fix a double close() on the error path

Simon Glass sjg at chromium.org
Mon May 2 01:12:24 CEST 2016


There is an extra close() call which is not needed.

Reported-by: Coverity (CID: 143065)
Signed-off-by: Simon Glass <sjg at chromium.org>
---

 tools/fit_image.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/fit_image.c b/tools/fit_image.c
index ddefa72..0551572 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -343,7 +343,6 @@ static int fit_build(struct image_tool_params *params, const char *fname)
 	if (ret != size) {
 		fprintf(stderr, "%s: Can't write %s: %s\n",
 			params->cmdname, fname, strerror(errno));
-		close(fd);
 		goto err;
 	}
 	close(fd);
-- 
2.8.0.rc3.226.g39d4020



More information about the U-Boot mailing list