[U-Boot] [PATCH 03/18] bootm: Align cache flush end address correctly

Heiko Schocher hs at denx.de
Tue May 3 09:51:06 CEST 2016


Hello Simon,

Am 03.05.2016 um 08:39 schrieb Simon Glass:
> Flushing part of the cache should be done on cache boundaries. Trying to
> flush part of a cache line is not supported and the request may be ignored
> or print warnings.
>
> Adjust the bootm code to align the end address to prevent this problem.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   common/bootm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: Heiko Schocher <hs at denx.de>

tested on the smartweb, corvus, taurus and axm board

Tested-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
>
> diff --git a/common/bootm.c b/common/bootm.c
> index c965326..7469c61 100644
> --- a/common/bootm.c
> +++ b/common/bootm.c
> @@ -435,7 +435,7 @@ static int bootm_load_os(bootm_headers_t *images, unsigned long *load_end,
>   		bootstage_error(BOOTSTAGE_ID_DECOMP_IMAGE);
>   		return err;
>   	}
> -	flush_cache(load, *load_end - load);
> +	flush_cache(load, ALIGN(*load_end - load, ARCH_DMA_MINALIGN));
>
>   	debug("   kernel loaded at 0x%08lx, end = 0x%08lx\n", load, *load_end);
>   	bootstage_mark(BOOTSTAGE_ID_KERNEL_LOADED);
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list