[U-Boot] [PATCH 2/2] mkimage: Add a quiet mode

[Joe Hershberger]

Hi Simon,

On Sun, May 1, 2016 at 2:55 PM, Simon Glass <sjg at chromium.org> wrote:
> Some build systems want to be quiet unless there is a problem. At present
> mkimage displays quite a bit of information when generating a FIT file. Add
> a '-q' flag to silence this.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>

With one nit below...

> ---
>
>  tools/imagetool.c | 3 ++-
>  tools/imagetool.h | 1 +
>  tools/mkimage.c   | 5 ++++-
>  3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/tools/imagetool.c b/tools/imagetool.c
> index 916ab96..08d191d 100644
> --- a/tools/imagetool.c
> +++ b/tools/imagetool.c
> @@ -51,7 +51,8 @@ int imagetool_verify_print_header(
>                                  * successful
>                                  */
>                                 if ((*curr)->print_header) {
> -                                       (*curr)->print_header(ptr);
> +                                       if (!params->quiet)

This test should be before the test for print_header being NULL above.
It would be silly to get an error saying that print_header is
undefined when you just asked to not call it.

> +                                               (*curr)->print_header(ptr);
>                                 } else {
>                                         fprintf(stderr,
>                                                 "%s: print_header undefined for %s\n",

<snip>