[U-Boot] [PATCH 2/2] atmel: bring in at91 pio4 device tree file and bindings

[Yang, Wenyou]

Hi Andreas,

> -----Original Message-----
> From: Andreas Bießmann [mailto:andreas at biessmann.org]
> Sent: 2016年5月3日 18:15
> To: Yang, Wenyou <Wenyou.Yang at atmel.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>
> Subject: Re: [U-Boot] [PATCH 2/2] atmel: bring in at91 pio4 device tree file and
> bindings
> 
> Dear Wenyou,
> 
> On 2016-04-07 04:16, Wenyou Yang wrote:
> > Bring in required device tree files from Linux.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> 
> There is a small typo below ...

Sorry, I didn't find the typo. Please point to me, thanks.

> 
> > ---
> >
> >  arch/arm/dts/sama5d2-pinfunc.h                     | 880
> > +++++++++++++++++++++
> >  .../pinctrl/atmel,at91-pio4-pinctrl.txt            |  65 ++
> >  2 files changed, 945 insertions(+)
> >  create mode 100644 arch/arm/dts/sama5d2-pinfunc.h  create mode 100644
> > doc/device-tree-bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> 
> <snip>
> 
> > diff --git
> > a/doc/device-tree-bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> > b/doc/device-tree-bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> > new file mode 100644
> > index 0000000..b048eac
> > --- /dev/null
> > +++ b/doc/device-tree-bindings/pinctrl/atmel,at91-pio4-pinctrl.txt
> > @@ -0,0 +1,65 @@
> > +* Atmel PIO4 Controller
> > +
> > +The Atmel PIO4 controller is used to select the function of a pin and
> > to
> > +configure it.
> > +
> > +Required properties:
> > +- compatible: "atmel,sama5d2-pinctrl".
> > +- reg: base address and length of the PIO controller.
> > +- interrupts: interrupt outputs from the controller, one for each
> > bank.
> > +- interrupt-controller: mark the device node as an interrupt
> > controller.
> > +- #interrupt-cells: should be two.
> > +- gpio-controller: mark the device node as a gpio controller.
> > +- #gpio-cells: should be two.
> > +
> > +Please refer to ../gpio/gpio.txt and
> > ../interrupt-controller/interrupts.txt for
> > +a general description of GPIO and interrupt bindings.
> > +
> > +Please refer to pinctrl-bindings.txt in this directory for details of
> > the
> > +common pinctrl bindings used by client devices.
> > +
> > +Subnode format
> > +Each node (or subnode) will list the pins it needs and how to
> > configured these
> 
> ... how to configure ...

Add more detailed example to show how to configure more clearly.

> 
> Would you upstream this via linux kernel?

Yes. I think so.

> 
> Reviewed-by: Andreas Bießmann <andreas at biessmann.org>
> 
> I'll pick this these days in a next branch for 2016.07, hopefully with a
> lot more dt bindings.
> 
> Best Regards
> 
> Andreas


Best Regards,
Wenyou Yang