[U-Boot] [PATCH 3/7] usb: dwc2: Throttle the setup packet resending

Stephen Warren swarren at wwwdotorg.org
Wed May 4 19:08:22 CEST 2016


On 05/03/2016 02:51 PM, Marek Vasut wrote:
> Abort the request in case any of the tokens in the packet failed to
> complete transfer 10 times. This is a precaution needed so that we
> don't end in endless loop when scanning the bus with some braindead
> devices.

Does this affect USB keyboards when SYS_USB_EVENT_POLL_VIA_CONTROL_EP is 
enabled? IIRC control transactions to HID devices can be held off for 
some duration based on polling intervals, and this patch might abort 
them early?

Or do we typically expect to use interrupt transfers for keyboards, so 
this isn't too relevant (although there are some platforms that enable 
SYS_USB_EVENT_POLL_VIA_CONTROL_EP). Maybe not DWC2 platforms though; I 
didn't check.


More information about the U-Boot mailing list