[U-Boot] [PATCH] ARM: fix ifdefs in ARMv8 lowlevel_init()

[Masahiro Yamada]

2016-04-29 3:45 GMT+09:00 Stephen Warren <swarren at wwwdotorg.org>:
> From: Stephen Warren <swarren at nvidia.com>
>
> Commit 724219a65f55 "ARM: always perform per-CPU GIC init" removed some
> ifdefs to unify the MULTIENTRY-vs-non-MULTIENTRY paths. However, the
> wrong endif was removed.

I missed this too
due to too much nested ifdefs.


> This patch adds back that missing endif, and
> adds a new ifdef to match the endif the now-correctly-terminated block
> used to match against. Use "git show -U25 724219a65f55" to see enough
> context to make the original issue clear.
>
> In practical terms, this makes no difference to runtime behaviour. The
> code that was incorrectly compiled into the binary when ifndef MULTIENTRY
> is a no-op for other cases, since branch_if_master evaluates to a hard-
> coded jump. The only issues were:
>
> - A few extra instructions were added to the binary.
> - The comment on the endif at the very end of the function, indicating
> which ifdef it matched, were wrong.
>
> An alternative might be to simply fix the comment on that trailing ifdef,
> but that only addresses the second point above, not the first.
>
> Fixes: 724219a65f55 ("ARM: always perform per-CPU GIC init")
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---

I bet it is OK this time.

Reviewed-by: Masahiro Yamada <yamada.masahiro at socionext.com>


-- 
Best Regards
Masahiro Yamada