[U-Boot] [PATCH v2] x86: qemu: Move qfw command over to cmd and add Kconfig entry

Tom Rini trini at konsulko.com
Tue May 10 04:17:45 CEST 2016


On Tue, May 10, 2016 at 09:20:45AM +0800, Bin Meng wrote:
> On Fri, May 6, 2016 at 10:40 PM, Tom Rini <trini at konsulko.com> wrote:
> > - Move the command portion of arch/x86/cpu/qemu/fw_cfg.c into
> >   cmd/qemu_fw_cfg.c
> > - Move arch/x86/include/asm/fw_cfg.h to include/qemu_fw_cfg.h
> > - Rename ACPI table portion to arch/x86/cpu/qemu/acpi_table.c
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> > Changes in v2:
> > - Depend on X86 (per Miao Yan)
> > ---
> >  arch/x86/cpu/mp_init.c         |   2 +-
> >  arch/x86/cpu/qemu/Makefile     |   3 +-
> >  arch/x86/cpu/qemu/acpi_table.c | 243 ++++++++++++++++++
> >  arch/x86/cpu/qemu/cpu.c        |   2 +-
> >  arch/x86/cpu/qemu/fw_cfg.c     | 570 -----------------------------------------
> >  arch/x86/cpu/qemu/qemu.c       |   2 +-
> >  arch/x86/include/asm/fw_cfg.h  | 157 ------------
> >  arch/x86/lib/acpi_table.c      |   2 +-
> >  cmd/Kconfig                    |   7 +
> >  cmd/Makefile                   |   1 +
> >  cmd/qemu_fw_cfg.c              | 343 +++++++++++++++++++++++++
> >  configs/qemu-x86_defconfig     |   1 +
> >  include/qemu_fw_cfg.h          | 162 ++++++++++++
> >  13 files changed, 763 insertions(+), 732 deletions(-)
> >  create mode 100644 arch/x86/cpu/qemu/acpi_table.c
> >  delete mode 100644 arch/x86/cpu/qemu/fw_cfg.c
> >  delete mode 100644 arch/x86/include/asm/fw_cfg.h
> >  create mode 100644 cmd/qemu_fw_cfg.c
> >  create mode 100644 include/qemu_fw_cfg.h
> >
> 
> Looks good.
> 
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> 
> Tom, will you pick this for this release, or next release?
> 
> Miao has a patch [1] to remove CONFIG_QEMU_ACPI_TABLE. If your patch
> comes first, Miao needs to rebase his and submit v2.

For the next release, and I'll leave it to you to pull in.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160509/110887e4/attachment.sig>


More information about the U-Boot mailing list