[U-Boot] [PATCH v2 1/3] dm: gpio: Add driver for MPC85XX GPIO controller

Mario Six mario.six at gdsys.cc
Tue May 10 15:43:44 CEST 2016


On Tue, May 10, 2016 at 3:26 PM, Timur Tabi <timur at tabi.org> wrote:

> Mario Six wrote:
>
>> On Tue, May 10, 2016 at 2:30 PM, Timur Tabi <timur at tabi.org
>> <mailto:timur at tabi.org>> wrote:
>>
>>     Mario Six wrote:
>>
>>         +       addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob,
>>         dev->of_offset,
>>         +                                                 "reg", 0,
>> &size);
>>
>>
>>     Why can't you use platform_get_resource()?
>>
>>
>> platform_get_resource is from the kernel, not U-Boot ;-) (Unless I've
>> missed
>> something and it has been implemented without me noticing).
>>
>
> Ugh, sorry.  I thought this was kernel code.  I make that mistake a lot.
>
> Now everything makes more sense.  I think
> fdtdec_get_addr_size_auto_noparent() is correct.
>
> Yeah, I make that mistake all the time, too :-)

We'll see what Simon has to say about v2.

Thanks for all the help!

Best regards,
Mario


More information about the U-Boot mailing list