[U-Boot] [PATCH] x86: qemu: fix ACPI Kconfig options

[Bin Meng]

Hi Miao,

On Wed, May 11, 2016 at 10:02 AM, Miao Yan <yanmiaobest at gmail.com> wrote:
> Hi Bin,
>
> 2016-05-10 11:11 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
>> On Mon, May 9, 2016 at 8:57 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> On Mon, May 9, 2016 at 3:27 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
>>>> CONFIG_GENENRATE_ACPI_TABLE controls the generation of ACPI table which
>>>> uses U-Boot's built-in methods and CONFIG_QEMU_ACPI_TABLE controls whether
>>>> to load ACPI table from QEMU's fw_cfg interface.
>>>>
>>>> But with commit "697ec431469ce0a4c2fc2c02d8685d907491af84 x86: qemu: Drop
>>>> our own ACPI implementation", there is only one way to support ACPI table
>>>> for QEMU targets which is the fw_cfg interface. Having two Kconfig options
>>>> for this purpose is not necessary any more, so this patch consolidates
>>>> the two.
>>>>
>>>> Signed-off-by: Miao Yan <yanmiaobest at gmail.com>
>>>> ---
>>>>  arch/x86/Kconfig           | 9 ---------
>>>>  arch/x86/cpu/qemu/fw_cfg.c | 2 +-
>>>>  arch/x86/lib/Makefile      | 2 +-
>>>>  3 files changed, 2 insertions(+), 11 deletions(-)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>>
>> Miao, please rebase this patch on top of u-boot-x86/next since Tom's
>> patch was applied first.
>
> Sure, I'll send v2.
>

When you rework the v2, could you please submit changes in addition to
Tom's patch to make sure there is no build errors as the workflow you
described. And maybe split the qfw command into two pieces? Sorry for
asking for a lot.

Regards,
Bin