[U-Boot] [PATCH v2] x86: qemu: Move qfw command over to cmd and add Kconfig entry

[Bin Meng]

On Wed, May 11, 2016 at 5:01 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
> 2016-05-11 10:11 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
>> Hi Miao,
>>
>> On Tue, May 10, 2016 at 10:10 AM, Miao Yan <yanmiaobest at gmail.com> wrote:
>>>>>
>>>>> +config CMD_QEMU_FW_CFG
>>>>> +       bool "qfw"
>>>>> +       depends on X86
>>>>> +       help
>>>>> +         This provides access to the QEMU firmware interface.  The main
>>>>> +         feature is to allow easy loading of files passed to qemu-system
>>>>> +         via -kernel / -initrd
>>>>>  endmenu
>>>>
>>>> This should really be "depends on QEMU". Sorry for my earlier comment.
>>>
>>>
>>> This line should be "depends on X86 && QEMU". Sorry I wasn't thinking right.
>>>
>>
>> This "depends on X86 && QEMU" still does not work as users can still
>> unselect this qfw command from menuconfig.
>
> The qfw commands are not mandatory, so users should be able to disable it.

Yes

>
>> We should make QEMU select this qfw command when CONFIG_GENERATE_ACPI_TABLE.
>
> GENERATE_ACPI_TABLE should select qfw core, not qfw command interface.

Correct

>
> Anyway I'll prepare patches for you guys to review.
>

Thanks!

Regards,
Bin