[U-Boot] drivers/crypto/fsl/Makefile: strange assignment

[Tom Rini]

On Thu, May 12, 2016 at 11:22:17PM -0300, Fabio Estevam wrote:
> On Thu, May 12, 2016 at 11:12 PM, Fabio Estevam <festevam at gmail.com> wrote:
> > Hi Raul,
> >
> > In commit 0200020bc2b8192 ("imx6: Added DEK blob generator command") you did:
> >
> > diff --git a/drivers/crypto/fsl/Makefile b/drivers/crypto/fsl/Makefile
> > index c0cf642..4aa91e4 100644
> > --- a/drivers/crypto/fsl/Makefile
> > +++ b/drivers/crypto/fsl/Makefile
> > @@ -8,5 +8,5 @@
> >
> >  obj-y += sec.o
> >  obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o
> > -obj-$(CONFIG_CMD_BLOB) += fsl_blob.o
> > +obj-$(CONFIG_CMD_BLOB)$(CONFIG_CMD_DEKBLOB) += fsl_blob.o
> >
> > ,which does not seem correct.
> >
> > Could you please take a look at this?
> 
> Would this be a fix for this?
> 
> --- a/drivers/crypto/fsl/Makefile
> +++ b/drivers/crypto/fsl/Makefile
> @@ -6,5 +6,7 @@
> 
>  obj-y += sec.o
>  obj-$(CONFIG_FSL_CAAM) += jr.o fsl_hash.o jobdesc.o error.o
> -obj-$(CONFIG_CMD_BLOB)$(CONFIG_CMD_DEKBLOB) += fsl_blob.o
> +ifeq ($(CONFIG_CMD_BLOB),y)
> +obj-$(CONFIG_CMD_DEKBLOB) += fsl_blob.o
> +endif
>  obj-$(CONFIG_RSA_FREESCALE_EXP) += fsl_rsa.o

No, CMD_DEKBLOB is just broken.  It's not set anywhere in-tree so we
can't quite say but I suspect they want fsl_blob.o included in case of
either, in which case we can just duplicate the entry.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160513/e6932c84/attachment.sig>