[U-Boot] [PATCH] cmd: replace the cast of the memory access to a fixed bit type in itest

Simon Glass sjg at chromium.org
Thu May 19 05:59:07 CEST 2016


On 3 May 2016 at 23:20, Masahiro Yamada <yamada.masahiro at socionext.com> wrote:
> From: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
>
> This patch fixes a bug that long word(.l) memory access in 'itest'
> command reads the 8bytes of the actual memory on 64-bit architecture.
> The cast to the memory pointer should use a fixed bit type.
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko at socionext.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
>  cmd/itest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


>
> diff --git a/cmd/itest.c b/cmd/itest.c
> index fb4d797..60626c7 100644
> --- a/cmd/itest.c
> +++ b/cmd/itest.c
> @@ -65,13 +65,13 @@ static long evalexp(char *s, int w)
>                 }
>                 switch (w) {
>                 case 1:
> -                       l = (long)(*(unsigned char *)buf);
> +                       l = (long)(*(u8 *)buf);
>                         break;
>                 case 2:
> -                       l = (long)(*(unsigned short *)buf);
> +                       l = (long)(*(u16 *)buf);
>                         break;
>                 case 4:
> -                       l = (long)(*(unsigned long *)buf);
> +                       l = (long)(*(u32 *)buf);
>                         break;
>                 }
>                 unmap_physmem(buf, w);
> --
> 1.9.1
>


More information about the U-Boot mailing list