[U-Boot] [PATCH v1 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option

[Viresh Kumar]

On 19-05-16, 07:22, Heiko Schocher wrote:
> Sorry for that ... I used patman  and forgot the "-m" no maintainer
> option ... Hmmm... on the other side, all involved people should be
> informed ... added Simon to Cc ... Simon?

In fact, your message wouldn't have hit the list as well.

> patman may create a big cc list, for example when moving config options
> to Kconfig ...
> 
> Makes it sense to add them all into bcc?

One way is to ignore all such people and don't add them at all. Adding
them in bcc will make them at least aware of this :)

> At least the ones the
> maintainer script finds?
> Is this easy to adapt in patman?

No idea.

> Hmm.. a problem is may "git send-mail", as there is no "--bcc-cmd" option ...
> So, all bcc addresses must be added with the "--bcc=address" option ...
> 
> >On 18-05-16, 16:18, Heiko Schocher wrote:
> >>diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
> >>index c4b6234..5e2e2b1 100644
> >>--- a/include/configs/spear-common.h
> >>+++ b/include/configs/spear-common.h
> >>@@ -106,9 +106,7 @@
> >>   * Default Environment Varible definitions
> >>   */
> >>  #if defined(CONFIG_SPEAR_USBTTY)
> >>-#define CONFIG_BOOTDELAY			-1
> >>  #else
> >>-#define CONFIG_BOOTDELAY			1
> >>  #endif
> >
> >Doesn't this ifdef look strange now ? :)

All I was saying is that we have this now:

  #if defined(CONFIG_SPEAR_USBTTY)
  #else
  #endif

So, you should have removed the ifdef completely.

> Indeed ... I have no such hw ... could you prepare a patch, which moves
> CONFIG_SPEAR_USBTTY to Kconfig, so if this option is selected, it
> set CONFIG_BOOTDELAY to -1 ?

I have left that company 4 years ago and don't have any hardware for
it. Over that I was never involved in uboot coding for the same :)

> So, in the first step I want to remove the lines
> #if defined(CONFIG_SPEAR_USBTTY)
> -#define CONFIG_BOOTDELAY			-1
> #else
> -#define CONFIG_BOOTDELAY			1
> #endif
> 
> in include/configs/spear-common.h complete.

Just kill the complete #ifdef/endif.

-- 
viresh