[U-Boot] [v2 PATCH 14/14] config: sandbox: enable qfw and cmd_qfw for testing

[Bin Meng]

Hi Miao,

On Fri, May 20, 2016 at 2:58 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
> Hi Bin,
>
> 2016-05-20 10:29 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
>> Hi Miao,
>>
>> On Fri, May 20, 2016 at 10:06 AM, Miao Yan <yanmiaobest at gmail.com> wrote:
>>> Hi Bin,
>>>
>>> 2016-05-19 17:08 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
>>>> Hi Miao,
>>>>
>>>> On Wed, May 18, 2016 at 5:40 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
>>>>> This patch enables qfw and cmd_qfw on sandbox for build coverage test
>>>>>
>>>>> Signed-off-by: Miao Yan <yanmiaobest at gmail.com>
>>>>> ---
>>>>>  configs/sandbox_defconfig | 2 ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig
>>>>> index afdf4a3..f19308d 100644
>>>>> --- a/configs/sandbox_defconfig
>>>>> +++ b/configs/sandbox_defconfig
>>>>> @@ -167,3 +167,5 @@ CONFIG_UNIT_TEST=y
>>>>>  CONFIG_UT_TIME=y
>>>>>  CONFIG_UT_DM=y
>>>>>  CONFIG_UT_ENV=y
>>>>> +CONFIG_QFW=y
>>>>> +CONFIG_CMD_QFW=y
>>>>> --
>>>>
>>>> Please do a 'make savedefconfig' and check the Kconfig options.
>>>
>>> I did a 'make savedefconfig' and there was a file generated
>>> 'defconfig' but with zero content. So what am I supposed to check ?
>>> Did you find something wrong with this one ?
>>>
>>
>> We need make sure the option order is correct in a defconfig file.
>
> Can you elaborate on this, what're the rules to add new config in
> sandbox_defconfig ? Is is based on the order in kconfig file ?
>

Yes, we should add new config in defconfig files according to their
order in Kconfig files.

>>
>> We can do it like this:
>>
>> $ make sandbox_defconfig
>> $ make savedefconfig
>>
>> Then check the difference between our updated sandbox_defconfig and
>> defconfig files.
>
> And they are supposed to be identical ?
>

The one generated by 'make savedefconfig' is supposed to have the
correct order, and without any redundant options.

Regards,
Bin