[U-Boot] [PATCH v2 03/18] x86: Fix up PIRQ routing table checksum earlier

Bin Meng bmeng.cn at gmail.com
Mon May 23 09:00:56 CEST 2016


On Thu, May 19, 2016 at 12:00 PM, Simon Glass <sjg at chromium.org> wrote:
> On 11 May 2016 at 08:44, Bin Meng <bmeng.cn at gmail.com> wrote:
>> PIRQ routing table checksum is fixed up in copy_pirq_routing_table(),
>> which is fine if we only write the configuration table once. But with
>> the SeaBIOS case, when we write the table for the second time, the
>> checksum will be fixed up to zero per the checksum algorithm, which
>> is caused by the checksum field not being zero before fix up, since
>> the checksum has already been calculated in the first run.
>>
>> To fix this, move the checksum fixup to create_pirq_routing_table(),
>> so that copy_pirq_routing_table() only does what its function name
>> suggests: copy the table to somewhere else.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>>  arch/x86/cpu/irq.c          | 4 ++++
>>  arch/x86/lib/pirq_routing.c | 4 ----
>>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list