[U-Boot] [PATCH v1 12/12] am335x, shc: add support for the am335x based bosch shc board

[Heiko Schocher]

Hello Tom,

Am 20.05.2016 um 21:49 schrieb Tom Rini:
> On Wed, May 18, 2016 at 04:18:38PM +0200, Heiko Schocher wrote:
>
>> U-Boot SPL 2016.03-rc3-00019-g6dfb4c2-dirty (Mar 09 2016 - 07:40:06)
>> SHC C3-Sample
>> MPU reference clock runs at 6 MHz
>> Setting MPU clock to 594 MHz
>> Enabling Spread Spectrum of 18 permille for MPU
>> Trying to boot from MMC
>> reading u-boot.img
>> reading u-boot.img
>>
>> U-Boot 2016.03-rc3-00019-g6dfb4c2-dirty (Mar 09 2016 - 07:05:35 +0100)
>>
>>         Watchdog enabled
>> I2C:   ready
>> DRAM:  512 MiB
>> reloc off 1f783000
>> MMC:   OMAP SD/MMC: 0, OMAP SD/MMC: 1
>> Net:   cpsw
>> U-Boot#
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>>
>> ---
>> This patch drops the following checkpatch warnings:
>>
>> warning: please write a paragraph that describes the config symbol fully
>>    I wrote a help ... I do not understand, whats missing here...
>>
>> warning: line over 80 characters
>>    On places where I think this does not disturb...
>>
>>    Patch:
>>    http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/259522
>>    is needed for clean compiling.
>
> We need to find some other way to solve this or move all of the
> partition stuff to Kconfig as well so we can default some stuff on and
> then turn it off in cases.

Ok ... hmm... moving to Kconfig seems the best option to me ...
tools/moveconfig is running ... moved
CONFIG_PARTITIONS
CONFIG_DOS_PARTITION
CONFIG_ISO_PARTITION
CONFIG_MAC_PARTITION
CONFIG_EFI_PARTITION

to Kconfig ... I add this patch to v2 ...

Hmm... rebased this patchset to current mainline and it fails working :-(

one error is fixed with patch:
http://patchwork.ozlabs.org/patch/624267/

but there is another mmc based error, as the board prints:

U-Boot SPL 2016.05-00135-g6202e44 (May 23 2016 - 14:54:16)
SHC
MPU reference clock runs at 6 MHz
Setting MPU clock to 594 MHz
Enabling Spread Spectrum of 18 permille for MPU
Trying to boot from MMC2
** Partition 1 not valid on device 1 **
spl_register_fat_device: fat register err - -1
spl_load_image_fat: error reading image u-boot.img, err - -1
spl: no partition table found
SPL: failed to boot from all boot devices

"git bisect" says:
$ git bisect bad
4b6e1fda107e5244e80ebc41865650ac2873dc88 is the first bad commit
$ git show 4b6e1fda107e5244e80ebc41865650ac2873dc88
commit 4b6e1fda107e5244e80ebc41865650ac2873dc88
Merge: 27bec5c 341392d
Author: Tom Rini <trini at konsulko.com>
Date:   Tue May 17 13:58:27 2016 -0400

     Merge git://git.denx.de/u-boot-dm

Seems in SPL it fails detecting the eMMC ... any hints?

>> +config 	
>> +	int "UART used for console"
>> +	range 1 6
>> +	default 1
>> +	help
>> +	  The AM335x SoC has a total of 6 UARTs (UART0 to UART5 as referenced
>> +	  in documentation, etc) available to it. The SHC board uses UART1
>> +	  for the console.
>
> Can you really have console on the other locations?  On the AM335x EVM,
> it was possible, and doubly so with people making RS232 capes for
> Beaglebones.  That's why it's exposed there.

You are right, removed.

>> +int do_panic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +{
>> +	hang_bosch("u-boot: uImage not found", 4);
>> +
>> +	/*NOTREACHED*/
>> +	return 0;
>> +}
>> +
>> +U_BOOT_CMD(
>> +	panic, 1, 0,    do_panic,
>> +	"Hang the CPU - Panic!",
>> +	""
>> +);
>
> No more commands in board directories, and we should be able to do this
> generically.  In fact, we should already be able to make fail to boot
> Linux fatal which I gather is what this is used for.

Yes, removed.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany