[U-Boot] wanting to confirm i'm setting the MAC address the right way

[Bin Meng]

On Wed, May 25, 2016 at 12:31 AM, Robert P. J. Day
<rpjday at crashcourse.ca> wrote:
>
>   i want to use the fdt_fixup_ethernet() routine to automate most of
> the work of setting the MAC address in the FDT before passing it to
> the kernel, so here's what i'm about to do, and i'd appreciate someone
> saying, "yup, looks good" if it will indeed work.
>
>   on either a MPC8280 or MPC8360 system, i will first set up the DTS
> file with some variation of:
>

To make it clear, the DTS file is the Linux kernel's, not U-Boot's.

>         aliases {
>                 ethernet0 = &ucc0;
>         };
>
>         ... snip ...
>
>                 ucc0:ucc at 2000 {
>                         device_type = "network";
>                         compatible = "ucc_geth";
>                         model = "UCC";
>                         device-id = <1>;
>                         reg = <0x2000 0x200>;
>                         interrupts = <0x20>;
>                         local-mac-address = [ 00 01 02 03 04 05 ];

Make it all 00s

>                         rx-clock = <0x1c>;  // CLK12
>                         tx-clock = <0x1b>;  // CLK11
>                         phy-handle = <&PHY0>;
>                 };
>
> at that point, given all the work done in fdt_fixup_ethernet(), i
> *think* that all i need to do in the board's ft_board_setup() routine
> is:
>
>   eth_setenv_enetaddr("ethaddr", <physical addr of 6-byte MAC address>);
>
> is that about it? it *looks* like all i have to do, and
> fdt_fixup_etherhet() will do all the rest.
>

yup, looks good :)

Regards,
Bin