[U-Boot] [PATCH v2 06/18] net: macb: Flush correct cache portion when sending

Andreas Bießmann andreas at biessmann.org
Sat May 28 14:35:42 CEST 2016


On 05.05.16 15:28, Simon Glass wrote:
> The end address of the cache flush must be cache-line-aligned since
> otherwise (at least on ARM926-EJS) the request is ignored. When the cache
> is enabled this means that packets are not sent.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Heiko Schocher <hs at denx.de>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>

Reviewed-by: Andreas Bießmann <andreas at biessmann.org>

> ---
> 
> Changes in v2: None
> 
>  drivers/net/macb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index f0af40c..ecdfc1b 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -280,7 +280,7 @@ static int _macb_send(struct macb_device *macb, const char *name, void *packet,
>  	barrier();
>  	macb_flush_ring_desc(macb, TX);
>  	/* Do we need check paddr and length is dcache line aligned? */
> -	flush_dcache_range(paddr, paddr + length);
> +	flush_dcache_range(paddr, paddr + ALIGN(length, ARCH_DMA_MINALIGN));
>  	macb_writel(macb, NCR, MACB_BIT(TE) | MACB_BIT(RE) | MACB_BIT(TSTART));
>  
>  	/*
> 


More information about the U-Boot mailing list