[U-Boot] [PATCH 1/2] spl: Remove bogus GD_FLG_SPL_INIT check

Chin Liang See clsee at altera.com
Tue May 31 02:34:00 CEST 2016


On Mon, 2016-05-30 at 18:39 +0200, Stefan Roese wrote:
> On 30.05.2016 17:22, Marek Vasut wrote:
> > Remove the check for GD_FLG_SPL_INIT in spl_relocate_stack_gd().
> > The check will always fail. This is because spl_relocate_stack_gd()
> > is called from ARM's crt0.S and it is called before board_init_r().
> > The board_init_r() calls spl_init(), which sets the GD_FLG_SPL_INIT
> > flag.
> > 
> > Note that reserving the malloc area in RAM is not a problem even
> > if the GD_FLG_SPL_INIT flag is not set.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Chin Liang See <clsee at altera.com>
> > Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> > Cc: Hans de Goede <hdegoede at redhat.com>
> > Cc: Pavel Machek <pavel at denx.de>
> > Cc: Stefan Roese <sr at denx.de>
> > Cc: Stephen Warren <swarren at nvidia.com>
> 
> Reviewed-by: Stefan Roese <sr at denx.de>
> 

Reviewed-by: Chin Liang See <clsee at altera.com>

Thanks
Chin Liang

> Thanks,
> Stefan


More information about the U-Boot mailing list