[U-Boot] [PATCH] ARM:dts: Added device tree for socfpga arria10 development kit sdmmc

Tien Fong Chee tfchee at altera.com
Tue Oct 4 12:23:41 CEST 2016


On Fri, 2016-09-30 at 10:28 -0500, Dinh Nguyen wrote:
>
> On 09/30/2016 03:12 AM, Tien Fong Chee wrote:
> > This is initial version of device tree for the Intel socfpga
> > arria10
>
> I would think that it's still an Altera SOCFPGA.
>
Okay.

> > development kit with sdmmc.
> >
> > Signed-off-by: Tien Fong Chee <tfchee at altera.com>
> > Cc: Marek Vasut <marex at denx.de>
> > Cc: Stefan Roese <sr at denx.de>
> > Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> > Cc: Chin Liang See <clsee at altera.com>
> > Cc: Tien Fong <skywindctf at gmail.com>
> > ---
> >  arch/arm/dts/socfpga_arria10.dtsi               |  866
> > +++++++++++++++++++++++
> >  arch/arm/dts/socfpga_arria10_handoff_sdmmc.dtsi |  457
> > ++++++++++++
> >  arch/arm/dts/socfpga_arria10_socdk_sdmmc.dts    |   30 +
> >  3 files changed, 1353 insertions(+), 0 deletions(-)
> >  create mode 100755 arch/arm/dts/socfpga_arria10.dtsi
> >  create mode 100755 arch/arm/dts/socfpga_arria10_handoff_sdmmc.dtsi
> >  create mode 100755 arch/arm/dts/socfpga_arria10_socdk_sdmmc.dts
> >
>
> Please recheck all of your file attributes. They should be 100644.
>
> > diff --git a/arch/arm/dts/socfpga_arria10.dtsi
> > b/arch/arm/dts/socfpga_arria10.dtsi
> > new file mode 100755
> > index 0000000..8ed5ff4
> > --- /dev/null
> > +++ b/arch/arm/dts/socfpga_arria10.dtsi
> > @@ -0,0 +1,866 @@
>
> [snip}
> > +
> > +           base_fpga_region {
> > +                   compatible = "fpga-region";
> > +                   fpga-mgr = <&fpga_mgr>;
> > +
> > +                   #address-cells = <0x1>;
> > +                   #size-cells = <0x1>;
> > +           };
>
> This has has not been upstreamed and accepted yet, I think.
>
Okay, i can remove this, i believe U-boot not requires info above, we
can add it back if it is required someday.

> > +
> > +           clkmgr at ffd04000 {
> > +                           compatible = "intc,clk-mgr";
>
> Whoa...why are you replacing "altr" with "intc"? If you switch from
> altr
> to intc, then none of the bindings have been accepted yet and needs
> to
> be resubmitted.
>
> Dinh

Looks like very huge impact, i would fixing it with altr.


More information about the U-Boot mailing list