[U-Boot] [PATCH 01/10] dm: imx: serial: support device tree
Stefano Babic
sbabic at denx.de
Tue Oct 4 15:02:44 CEST 2016
Hi Stefan,
On 29/08/2016 02:00, Stefan Agner wrote:
>>
>> I have applied it, I just noted a slight drawback because this breaks
>> boards that do not have CONFIG_FIT set.
>
> Hm, maybe due to missing CONFIG_OF_LIBFDT? Do you want me to fix it, do
> you have a certain board you can reproduce it?
No, I have found it. The patchset breaks two boards (gwventana and
cmx6), and the reason is that lib/fdtdec.c is not compiled. This is
because CONFIG_OF_CONTROL is not set for these two boards, but as far as
I understand this should be not set, because there is no device tree for
these two boards.
The issue is generate by the feature use_dte: in fact:
plat->use_dte = fdtdec_get_bool(gd->fdt_blob, dev->of_offset,
"fsl,dte-mode");
but for boards without DT, fdtdec is not built and gd->fdt_blob is maybe
not set.
Can you take a look ? What do you think about it ?
The second issue is related to CONFIG_CUSTOM_BOARDINFO:
arm: + colibri_imx7
+Error: You must add new CONFIG options using Kconfig
+The following new ad-hoc CONFIG options were detected:
+CONFIG_CUSTOM_BOARDINFO
+
+Please add these via Kconfig instead. Find a suitable Kconfig
+file and add a 'config' or 'menuconfig' option.
This is related to:
Author: Stefan Agner <stefan.agner at toradex.com>
Date: Mon Aug 1 22:50:24 2016 -0700
configs: enable device tree for Colibri iMX7
Enable device tree configuration and specify default device tree
for Toradex Colibri iMX7. Also configure CONFIG_CUSTOM_BOARDINFO
to avoid that board info get printed twice (once from the device
tree and one from the runtime detection in board specific code).
Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
What about to split it ? I will let this patch to just enable the device
tree, and let fix the double output with a follow up patch. What do you
think ?
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
More information about the U-Boot
mailing list