[U-Boot] [PATCH] cmd: cros_ec: Move crosec commands to cmd subdirectory

[Simon Glass]

Hi Moritz,

On 3 October 2016 at 16:53, Moritz Fischer <moritz.fischer at ettus.com> wrote:
> Move crosec commands from drivers/misc/cros_ec.c to
> cmd/cros_ec.c
>
> Signed-off-by: Moritz Fischer <moritz.fischer at ettus.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: Miao Yan <yanmiaobest at gmail.com>
> Cc: Masahiro Yamada <yamada.masahiro at socionext.com>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Przemyslaw Marczak <p.marczak at samsung.com>
> Cc: Maxime Ripard <maxime.ripard at free-electrons.com>
> Cc: Nishanth Menon <nm at ti.com>
> Cc: u-boot at lists.denx.de
> ---
>  cmd/Kconfig            |  12 ++
>  cmd/Makefile           |   1 +
>  cmd/cros_ec.c          | 366 +++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/misc/cros_ec.c | 348 ----------------------------------------------
>  include/cros_ec.h      |  11 ++
>  5 files changed, 390 insertions(+), 348 deletions(-)
>  create mode 100644 cmd/cros_ec.c

Acked-by: Simon Glass <sjg at chromium.org>

But please see below.

>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 86554ea..141281f 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -677,6 +677,18 @@ config CMD_TPM_TEST
>
>  endmenu
>
> +menu "Firmware commands"
> +config CMD_CROS_EC
> +       bool "Enable crosec command"
> +       depends on CROS_EC

Can this be enabled by default if CROS_EC is enabled? At present I
think your change will disable it.

e.g.

   default y

> +       help
> +         Enable command-line access to the Chrome OS EC (Embedded
> +         Controller). This provides the 'crosec' command which has
> +         a number of sub-commands for performing EC tasks such as
> +         updating its flash, accessing a small saved context area
> +         and talking to the I2C bus behind the EC (if there is one).
> +endmenu
> +