[U-Boot] [PATCH 05/12] dm: core: Add a function to get a uclass name

Bin Meng bmeng.cn at gmail.com
Wed Oct 5 11:20:15 CEST 2016


On Mon, Oct 3, 2016 at 11:12 AM, Simon Glass <sjg at chromium.org> wrote:
> It is useful in debug() statements to display the name of the uclass for a
> device. Add a simple function to provide this.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>  drivers/core/uclass.c | 9 +++++++++
>  include/dm/uclass.h   | 8 ++++++++
>  2 files changed, 17 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

One comment below:

> diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c
> index de602ae..60610e5 100644
> --- a/drivers/core/uclass.c
> +++ b/drivers/core/uclass.c
> @@ -148,6 +148,15 @@ int uclass_get(enum uclass_id id, struct uclass **ucp)
>         return 0;
>  }
>
> +const char *uclass_get_name(enum uclass_id id)
> +{
> +       struct uclass *uc;
> +
> +       if (uclass_get(id, &uc))
> +               return NULL;
> +       return uc->uc_drv->name;
> +}
> +
>  int uclass_find_device(enum uclass_id id, int index, struct udevice **devp)
>  {
>         struct uclass *uc;
> diff --git a/include/dm/uclass.h b/include/dm/uclass.h
> index 84f05bc..34e2bdc 100644
> --- a/include/dm/uclass.h
> +++ b/include/dm/uclass.h
> @@ -119,6 +119,14 @@ struct uclass_driver {
>  int uclass_get(enum uclass_id key, struct uclass **ucp);
>
>  /**
> + * uclass_get_name() - Get the name of a uclass drive

drive -> driver

> + *
> + * @id: ID to look up
> + * @returns the name of the uclass driver for that ID, or NULL if none
> + */
> +const char *uclass_get_name(enum uclass_id id);
> +
> +/**
>   * uclass_get_device() - Get a uclass device based on an ID and index
>   *
>   * The device is probed to activate it ready for use.
> --

Regards,
Bin


More information about the U-Boot mailing list