[U-Boot] [PATCH v2 5/9] tegra: select ARM_GIC for Tegra TK1s

[Antoine Tenart]

Hi Stephen,

On Thu, Oct 06, 2016 at 10:15:06AM -0600, Stephen Warren wrote:
> On 10/06/2016 08:33 AM, Antoine Tenart wrote:
> >Select the newly introduced ARM_GIC option to the relevant configuration
> >which also have a psci implementation.
> 
> >diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-tegra/tegra124/Kconfig
> 
> > config TARGET_JETSON_TK1
> > 	bool "NVIDIA Tegra124 Jetson TK1 board"
> >+	select ARM_GIC
> > 	select CPU_V7_HAS_NONSEC
> > 	select CPU_V7_HAS_VIRT
> > 	select ARCH_SUPPORT_PSCI
> >
> > config TARGET_CEI_TK1_SOM
> > 	bool "Colorado Engineering Inc Tegra124 TK1-som board"
> >+	select ARM_GIC
> > 	select CPU_V7_HAS_NONSEC if !SPL_BUILD
> > 	select CPU_V7_HAS_VIRT if !SPL_BUILD
> > 	help
> 
> This isn't correct; all Tegra variants have an ARM GIC; it's not
> board-specific. Shouldn't CONFIG_TEGRA or CONFIG_TEGRA_COMMON select
> ARM_GIC?

I focused on adding ARM_GIC for targets using PSCI, but I was hopping
for comments like this one :)

I'll move the ARM_GIC selection to CONFIG_TEGRA or CONFIG_TEGRA_COMMON
then.

Thanks!

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161006/b5aa5a44/attachment.sig>