[U-Boot] [PATCH][v3] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS

[Pratiyush Srivastava]

> -----Original Message-----
> From: york sun
> Sent: Thursday, October 06, 2016 10:02 PM
> To: Pratiyush Srivastava <pratiyush.srivastava at nxp.com>; u-
> boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>
> Subject: Re: [PATCH][v3] board: ls1012afrdm: overwrite
> CONFIG_EXTRA_ENV_SETTINGS
> 
> On 10/04/2016 04:38 AM, Pratiyush Mohan Srivastava wrote:
> > LS1012AFRDM has 512MB of DDR.
> > So update Kernel load address as 0x96000000 instead of default
> > 0xa0000000.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>
> > Signed-off-by: Pratiyush Mohan Srivastava
> > <pratiyush.srivastava at nxp.com>
> > ---
> > Changes for v3:
> > 	- Rebased v2 patch to master
> > 	- Removed "initrd_high=0xffffffff\0"
> > 	- Removed console variable "console=ttyAMA0,115200n8\0"
> >
> > Changes for v2: Incorporated York's comments
> >  	- Removed ramdisk_addr, ramdisk_size
> > 	- Updated UART baud-rate.
> >
> >  include/configs/ls1012afrdm.h | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/include/configs/ls1012afrdm.h
> > b/include/configs/ls1012afrdm.h index 612f243..5763d86 100644
> > --- a/include/configs/ls1012afrdm.h
> > +++ b/include/configs/ls1012afrdm.h
> > @@ -20,6 +20,18 @@
> >  #define CONFIG_SYS_MEMTEST_START	0x80000000
> >  #define CONFIG_SYS_MEMTEST_END		0x9fffffff
> >
> > +#undef CONFIG_EXTRA_ENV_SETTINGS
> > +#define CONFIG_EXTRA_ENV_SETTINGS              \
> > +       "verify=no\0"                           \
> 
> Why do you need this?
[Pratiyush>] This is needed for fast-boot.
> 
> > +       "hwconfig=fsl_ddr:bank_intlv=auto\0"    \
> 
> This board doesn't use Freescale DDR driver. This hwconfig is not used.
[Pratiyush>] ok I will remove it
> 
> > +       "loadaddr=0x80100000\0"                 \
> > +       "kernel_addr=0x100000\0"                \
> > +       "fdt_high=0xffffffffffffffff\0"         \
> > +       "initrd_high=0xffffffffffffffff\0"      \
> > +       "kernel_start=0xa00000\0"               \
> > +       "kernel_load=0x96000000\0"              \
> > +       "kernel_size=0x2800000\0"
> > +
> 
> York