[U-Boot] [PATCH] board: ge: bx50v3: Pass video bootargs for b850v3

[Stefano Babic]

Hi Akshay,

On 06/10/2016 09:37, Stefano Babic wrote:
> On 22/09/2016 20:55, Akshay Bhat wrote:
>> From: Ken Lin <ken.lin at advantech.com.tw>
>>
>> Due to clock source restrictions on i.MX6, certain pixel clock rates can
>> not be supported. Hence default the resolution/frame rate during boot to a
>> supported value by passing video bootargs 1024x768 at 60 for
>> HDM5b0d03b306b8d3010835d8b191bfc0581735021fI (Display Port1) and LVDS (Display Port2) on B850v3.
>>
>> Signed-off-by: Ken Lin <ken.lin at advantech.com.tw>
>> Signed-off-by: Akshay Bhat <akshay.bhat at timesys.com>
>> ---
>>  include/configs/ge_bx50v3.h | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h
>> index 52f096e..b905104 100644
>> --- a/include/configs/ge_bx50v3.h
>> +++ b/include/configs/ge_bx50v3.h
>> @@ -15,6 +15,7 @@
>>  #include <asm/arch/imx-regs.h>
>>  #include <asm/imx-common/gpio.h>
>>  
>> +#define CONFIG_BOOTARGS_EXTRA
>>  #if defined(CONFIG_TARGET_GE_B450V3)
>>  #define CONFIG_BOARD_NAME	"General Electric B450v3"
>>  #define CONFIG_DEFAULT_FDT_FILE	"/boot/imx6q-b450v3.dtb"
>> @@ -24,6 +25,9 @@
>>  #elif defined(CONFIG_TARGET_GE_B850V3)
>>  #define CONFIG_BOARD_NAME	"General Electric B850v3"
>>  #define CONFIG_DEFAULT_FDT_FILE	"/boot/imx6q-b850v3.dtb"
>> +#undef CONFIG_BOOTARGS_EXTRA
>> +#define CONFIG_BOOTARGS_EXTRA	"video=DP-1:1024x768 at 60 " \
>> +				"video=HDMI-A-1:1024x768 at 60 "
>>  #else
>>  #define CONFIG_BOARD_NAME	"General Electric BA16 Generic"
>>  #define CONFIG_DEFAULT_FDT_FILE	"/boot/imx6q-ba16.dtb"
>> @@ -166,7 +170,8 @@
>>  			"echo 'U-Boot upgraded. Please reset'; " \
>>  		"fi\0" \
>>  	"setargs=setenv bootargs console=${console},${baudrate} " \
>> -		"root=/dev/${rootdev} rw rootwait cma=128M\0" \
>> +		"root=/dev/${rootdev} rw rootwait cma=128M " \
>> +		CONFIG_BOOTARGS_EXTRA "\0" \
>>  	"loadbootscript=" \
>>  		"ext2load ${dev} ${devnum}:${partnum} ${loadaddr} ${script};\0" \
>>  	"bootscript=echo Running bootscript from ${dev}:${devnum}:${partnum};" \
>>
> 
> Applied to u-boot-imx, thanks !
> 

But not pushed: in fact, this canoot be built anymore. You add a new
CONFIG_ (but do you really need it ?), and this is not allowed anymore.
It generates a build error because all CONFIG_ should be set via Kconfig.

       arm:  +   ge_b850v3
+Error: You must add new CONFIG options using Kconfig
+The following new ad-hoc CONFIG options were detected:
+CONFIG_BOOTARGS_EXTRA
+

I think it os ok if you rename it and let it as local #define in your
configuration file.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================