[U-Boot] [PATCH] arm: imx: add i.MX53 Beckhoff CX9020 Embedded PC

[Stefano Babic]

Hi Patrick,

I see a couple of small issues by merging this:

On 28/09/2016 17:46, linux-kernel-dev at beckhoff.com wrote:
> From: Patrick Bruenn <p.bruenn at beckhoff.com>
> 
> Add CX9020 board based on mx53loco.
> Add simplified imx53 base device tree from kernel v4.8-rc8, to reuse
> serial_mxc with DTE and prepare for device tree migration of other
> functions and imx53 devices.
> 
> The CX9020 differs from i.MX53 Quick Start Board by:
> - use uart2 instead of uart1
> - DVI-D connector instead of VGA
> - no audio
> - CCAT FPGA connected to emi
> - enable rtc
> 
> Signed-off-by: Patrick Bruenn <p.bruenn at beckhoff.com>
> 
> ---


CONFIG_CMD_CCAT: you add an own CONFIG_, and all CONFIG_ should be
selected via Kconfig. This generates a build error for your board.

> +++ b/board/beckhoff/mx53cx9020/mx53cx9020.c
> @@ -0,0 +1,564 @@
> +/*
> + * Copyright (C) 2015  Beckhoff Automation GmbH & Co. KG
> + * Patrick Bruenn <p.bruenn at beckhoff.com>
> + *
> + * Based on Freescale's Linux i.MX mx53loco.c file:
> + * Copyright (C) 2011 Freescale Semiconductor, Inc.
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <asm/io.h>
> +#include <asm/arch/imx-regs.h>
> +#include <asm/arch/sys_proto.h>
> +#include <asm/arch/crm_regs.h>
> +#include <asm/arch/clock.h>
> +#include <asm/arch/iomux-mx53.h>
> +#include <asm/arch/clock.h>
> +#include <asm/errno.h>

This is not found and you do not need it (tested with gcc 5.4). If you
rely on toolchain's header, you can drop it. This generates a build
error as well.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================