[U-Boot] [PATCH] power: twl6030: fix code refactoring

Nicolae Rosia nicolae.rosia.oss at gmail.com
Thu Oct 13 12:47:53 CEST 2016


From: Nicolae Rosia <nicolae.rosia at gmail.com>

Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code
but the register read ended up in the wrong if branch.
Currently, the else branch checks a variable which is always 0.

Signed-off-by: Nicolae Rosia <nicolae_rosia at mentor.com>
---
 drivers/power/twl6030.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/power/twl6030.c b/drivers/power/twl6030.c
index 05c79be..cd53200 100644
--- a/drivers/power/twl6030.c
+++ b/drivers/power/twl6030.c
@@ -231,9 +231,9 @@ void twl6030_power_mmc_init(int dev_index)
 		/* Enable P1 output for VMMC */
 		twl6030_i2c_write_u8(TWL6030_CHIP_PM, TWL6030_VMMC_CFG_STATE,
 			TWL6030_CFG_STATE_P1 | TWL6030_CFG_STATE_ON);
-
-		twl6030_i2c_read_u8(TWL6030_CHIP_PM, TWL6030_PH_STS_BOOT, &value);
 	} else if (dev_index == 1) {
+		twl6030_i2c_read_u8(TWL6030_CHIP_PM, TWL6030_PH_STS_BOOT,
+				    &value);
 		/* BOOT2 indicates 1.8V/2.8V VAUX1 for eMMC */
 		if (value & TWL6030_PH_STS_BOOT2) {
 			/* 1.8V voltage output for VAUX1 */
-- 
2.5.5



More information about the U-Boot mailing list