[U-Boot] [PATCH 2/2] spi: ti_qspi: Fix baudrate divider calculation

R, Vignesh vigneshr at ti.com
Fri Oct 14 12:48:40 CEST 2016



On 10/14/2016 12:27 PM, Jagan Teki wrote:
> On Fri, Oct 14, 2016 at 10:54 AM, Vignesh R <vigneshr at ti.com> wrote:
...
>>>>  DECLARE_GLOBAL_DATA_PTR;
>>>>
>>>> @@ -118,7 +119,7 @@ static void ti_spi_set_speed(struct ti_qspi_priv *priv, uint hz)
>>>>         if (!hz)
>>>>                 clk_div = 0;
>>>>         else
>>>> -               clk_div = (priv->fclk / hz) - 1;
>>>> +               clk_div = DIV_ROUND_UP(priv->fclk, hz) - 1;
>>>
>>> Better to have a checks for min and max divider values or mask.
>>
>> That code already exists in this function.
> 
> True but it's unnecessary to print the wrong baud prior to checking.
> Do the check, then print/debug and finally write reg.
> 

Posted a v2 in reply to the patch. Thanks for the review!

Regards
Vignesh


More information about the U-Boot mailing list