[U-Boot] [PATCH] power: twl6030: fix code refactoring

[Paul Kocialkowski]

Hi,

Le samedi 15 octobre 2016 à 20:41 +0300, Nicolae Rosia a écrit :
> Hi,
> 
> On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski <contact at paulk.fr> wrote:
> > 
> > Le jeudi 13 octobre 2016 à 13:47 +0300, Nicolae Rosia a écrit :
> > > 
> > > From: Nicolae Rosia <nicolae.rosia at gmail.com>
> > > 
> > > Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code
> > > but the register read ended up in the wrong if branch.
> > > Currently, the else branch checks a variable which is always 0.
> > 
> > Good catch! Sorry for including that regression in the first place, I should
> > have checked the patch more thoroughly.
> No worries!
> 
> > 
> > See comment below.
> > The indentation before &value is inconsistent with what is done in the rest
> > of
> > the file. I think you should either just move the line as it was or only use
> > one
> > extra tab indent for the new line. Since this file breaks the 80 chars limit
> > in
> > a few places, I would tend to prefer the former.
> > 
> checkpatch.pl was complaining, that's why I formatted it.

Then I think you should fix the rest of the file accordingly.

It doesn't make sense to introduce a variation in the coding style, as it
creates inconsistency. IMO this is worse than having only subsequent changes
conform to the global U-Boot coding style.

> @Tom Rini, can you apply it either way?
> 
> Best regards,
> Nicolae
-- 
Paul Kocialkowski, developer of free digital technology at the lower levels

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161015/af328088/attachment.sig>