[U-Boot] [PATCH 3/3] mx6: synchronize SPL to u-boot offset

[Marek Vasut]

On 10/15/2016 09:17 PM, Max Krummenacher wrote:
> Hi Marak
> 
>>> --- a/include/configs/imx6_spl.h
>>> +++ b/include/configs/imx6_spl.h
>>> @@ -23,6 +23,8 @@
>>>   *    which consists of a 4K header in front of us that contains
>>> the IVT, DCD
>>>   *    and some padding thus 'our' max size is really 0x00908000 -
>>> 0x00918000
>>>   *    or 64KB
>>> + *  - Padding between start of SPL(with IVT...) and U-Boot is
>>> 68KB, SPL starts
>>> + *    at 1KB, U-Boot at 69kB into the storage media.
>>>   */
>>>  #define CONFIG_SYS_THUMB_BUILD
>>>  #define CONFIG_SPL_LDSCRIPT	"arch/arm/cpu/armv7/omap
>>> -common/u-boot-spl.lds"
>>> @@ -38,6 +40,7 @@
>>>  /* MMC support */
>>>  #if defined(CONFIG_SPL_MMC_SUPPORT)
>>>  #define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR	138 /*
>>> offset 69KB */
>>> +#define CONFIG_SPL_PAD_TO			0x11000 /* offset
>>> 68KB */
>>
>> Does this mess up boards which can boot from both SD and other boot
>> media (NAND, SPI NOR, PNOR...) ?
> 
> Good point.
> CONFIG_SPL_PAD_TO is used to create the combined SPL/U-Boot binary.
> While I have not found any use of this by any config which includes
> imx6_spl.h it might hinder future boards.
> So it's probably best to define CONFIG_SPL_PAD_TO in the individual
> board configs and skip this patch.

So how did you come up with this patch ? What was the thought process?


-- 
Best regards,
Marek Vasut