[U-Boot] [PATCH] ARM: zynq: Extend picozed board support

[Michal Simek]

On 17.10.2016 16:03, Oscar Gomez Fuente wrote:
> Hi everyone,
> 
> Sorry for the errors, I know is a very simple patch but it's my first time.
> 
> ------------------------------------------------------------------------------------------
>> Add missing DT nodes.
>>
>> Signed-off-by: Oscar Gomez Fuente <oscargomezf at gmail.com>
>> ---
>>  arch/arm/dts/zynq-picozed.dts | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
>> index 3408df8..5f703a2 100644
>> --- a/arch/arm/dts/zynq-picozed.dts
>> +++ b/arch/arm/dts/zynq-picozed.dts
>> @@ -26,3 +26,23 @@
>>       u-boot,dm-pre-reloc;
>>       status = "okay";
>>  };
>> +
> 
> please also extended aliases list.
> ------------------------------------------------------------------------------------------
> -> Ok, Understood.
> 
> ------------------------------------------------------------------------------------------
>> +&gem0 {
>> +     status = "okay";
>> +     phy-mode = "rgmii-id";
>> +     phy-handle = <&ethernet_phy>;
>> +
>> +     ethernet_phy: ethernet-phy at 0 {
>> +             reg = <0>;
> 
> I expect that this is on board 88e1512
> ------------------------------------------------------------------------------------------
> -> Yes, this is on board 88e1512. Do I have to modify anything? I think
> that's good, isn't it?

nope.

> 
> ------------------------------------------------------------------------------------------
>> +     };
>> +};
>> +
>> +&qspi {
>> +     u-boot,dm-pre-reloc;
>> +     status = "okay";
>> +     };
> 
> wrong indentation here.
> ------------------------------------------------------------------------------------------
> -> Ok, sorry.
> 
> ------------------------------------------------------------------------------------------
>> +
>> +&sdhci0 {
> 
> is this sd0 or sd1 hard IP? I expect that this is emmc right?
> ------------------------------------------------------------------------------------------
> -> sdhci0 is sd0 IP, the Sd Card on the PicoZed FMC Carrier.


Then this shouldn't be the part of this file. picozed is SOM and you
should describe all stuff which are just on this module.
If you want to support Picozed with any carrier board you should
describe it separately. The best carrier and include picozed dts.


> 
>> +     u-boot,dm-pre-reloc;
>> +     status = "okay";
>> +};
>>
> 
> If everything is ok now, I'll send the patch to mainline mailing list
> instead of xilinx one.

I have changed emails.

> 
> 
> Another question: Do you know if there is any perl script to check dts
> files before sending it? I've run the ./scripts/checkpatch.pl to check the
> arch/arm/dts/zynq-picozed.dts file and I didn't get any error.

checkpatch is not designed to parse DTS files and I am not sure if there
is any parser.

Thanks,
Michal