[U-Boot] [PATCH] test/py: Fix exception, do not parametrize with empty set

Stephen Warren swarren at wwwdotorg.org
Tue Oct 18 00:21:29 CEST 2016


On 10/17/2016 04:01 PM, Stephen Warren wrote:
> On 10/17/2016 01:18 PM, Brüns, Stefan wrote:
>> On Montag, 17. Oktober 2016 12:11:26 CEST Stephen Warren wrote:
>>> On 10/16/2016 12:17 PM, Stefan Brüns wrote:
>>>> If the parameter set is empty, the pytest setup fails:
>>>> ---
>>>>
>>>>     call: <CallInfo when='setup' exception: got empty parameter set
>>>>     ['env__dfu_config'], function test_dfu at [...]test_dfu.py:107>
>>>>
>>>> ---
>>>>
>>>> This aborts pytest_runtest_makereport and later leads to an exception
>>>> during the report generation, as the call to log.start_section(...)
>>>> is never executed:
>>>> ---
>>>>
>>>>     Exception: Block nesting mismatch:
>>>>     "test_dfu[env__usb_dev_port0-env__dfu_config0]" ""
>>>>
>>>> ---
>>>
>>> How do you trigger this? I believe my test setup has many cases where
>>> the test you added would trigger, but without the issues you mention,
>>> but I'm not 100% sure since I don't know for sure what is causing this
>>> issue.
>>>
>>> Which pytest version do you have? I appear to have 2.5.1 (on Ubuntu
>>> Trusty)
>>
>> 1. You need "dfu_configs" to be empty
>> 2. Maybe its pytest version dependent, IIRC I have 3.0.2
>>
>> The first error above can be seen when running pytest with "--debug",
>> it is
>> written to IIRC pytestdebug.log
>
> Looks like this is a bug in pytest 3, and has been fixed upstream:
>
> https://github.com/pytest-dev/pytest/issues/1849
> Pytest 3.0 does not accept empty list in fixture

Actually, I take that back; that's something else. I'll keep looking.



More information about the U-Boot mailing list