[U-Boot] [PATCH] ARM: zynq: Extend picozed board support

[Michal Simek]

On 17.10.2016 17:33, Oscar Gomez Fuente wrote:
> Ok Michal,
> 
> Then you're suggesting change the zynq-picozed.dts file to:

dtsi.

> 
> diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
> index 3408df8..d8ed298 100644
> --- a/arch/arm/dts/zynq-picozed.dts
> +++ b/arch/arm/dts/zynq-picozed.dts
> @@ -14,6 +14,8 @@
> 
>         aliases {
>                 serial0 = &uart1;
> +               spi0 = &qspi;
> +               ethernet0 = &gem0;
>         };
> 
>         memory {
> @@ -26,3 +28,18 @@
>         u-boot,dm-pre-reloc;
>         status = "okay";
>  };
> +
> +&qspi {
> +       u-boot,dm-pre-reloc;
> +       status = "okay";
> +};

keep node names sorted.

> +
> +&gem0 {
> +       status = "okay";
> +       phy-mode = "rgmii-id";
> +       phy-handle = <&ethernet_phy>;
> +
> +       ethernet_phy: ethernet-phy at 0 {
> +               reg = <0>;
> +       };
> +};
> 
> And add a new dts file with the configuration of the PizoZed FMC Carrier V2
> (in this case V2. Avnet has two PicoZed FMC carriers V1 and V2). For
> example: zynq-picozed-fmc-v2.dts
> 
> *
>  * Avnet PicoZed FMC carrier V2 DTS
>  *
>  * Copyright (C) 2015 Xilinx, Inc.
>  *
>  * SPDX-License-Identifier: GPL-2.0+
>  */
> /dts-v1/;

Depends how zynq-picozed.dtsi will look but this line above can be
already there.

> #include "zynq-picozed.dts"
> 
> / {
> compatible = "xlnx,zynq-picozed", "xlnx,zynq-7000";

here
"xlnx,zynq-picozed-fmc-v2", "xlnx,zynq-picozed", "xlnx,zynq-7000";


> 
> aliases {
> mmc0 = &sdhci0;
> };
> };
> 
> &sdhci0 {
> u-boot,dm-pre-reloc;
> status = "okay";
> };
> 
> Do you think the is the best way?

with changes above it looks reasonable.

Thanks,
Michal