[U-Boot] [PATCH 7/8] travis-ci: Drop 'TEST_CMD'

Heiko Schocher hs at denx.de
Fri Oct 21 09:54:56 CEST 2016


Hello Tom,

Am 20.10.2016 um 21:26 schrieb Tom Rini:
> We don't need to use TEST_CMD in order to run tests.  We need a BUILDMAN
> and TOOLCHAIN variable to avoid having to duplicate logic or write some
> wrapper function.  But this makes the tests harder as we add more
> complex examples.
>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>   .travis.yml | 26 ++++++++++----------------
>   1 file changed, 10 insertions(+), 16 deletions(-)

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko

>
> diff --git a/.travis.yml b/.travis.yml
> index 8ebcfaf996ab..25b0023d631b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -57,10 +57,6 @@ before_script:
>     - if [[ "${TOOLCHAIN}" == *xtensa* ]]; then ./tools/buildman/buildman --fetch-arch xtensa ; fi
>
>   script:
> - # the execution sequence for each test
> - - if [[ "${TEST_CMD}" != "" ]]; then
> -     ${TEST_CMD};
> -   fi
>    # Exit code 129 means warnings only.
>    - if [[ "${BUILDMAN}" != "" ]]; then
>        set +e;
> @@ -154,24 +150,22 @@ matrix:
>
>       # QA jobs for code analytics
>       # static code analysis with cppcheck (we can add --enable=all later)
> -    - env:
> -        - TEST_CMD="cppcheck --force --quiet --inline-suppr ."
> +    - script:
> +        - cppcheck --force --quiet --inline-suppr .
>       # search for TODO within source tree
> -    - env:
> -        - TEST_CMD="grep -r TODO ."
> +    - script:
> +        - grep -r TODO .
>       # search for FIXME within source tree
> -    - env:
> -        - TEST_CMD="grep -r FIXME ."
> +    - script:
> +        - grep -r FIXME .
>       # search for HACK within source tree and ignore HACKKIT board
> -    - env:
> -        - TEST_CMD="grep -r HACK . | grep -v HACKKIT"
>         script:
>           - grep -r HACK . | grep -v HACKKIT
>       # some statistics about the code base
> -    - env:
> -        - TEST_CMD="sloccount ."
> +    - script:
> +        - sloccount .
>       # test/py
> -    - env:
> -        - TEST_CMD="./test/py/test.py --bd sandbox --build"
> +    - script:
> +        - ./test/py/test.py --bd sandbox --build
>
>   # TODO make it perfect ;-r
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list